It allows to show iframes on top of a windowed plugin. This is covered by layout test plugins/iframe-shims.html that for some reason works when run with WTR. It seems than the fake mouse events used by WTR reach the buttons that are hidden. This doesn't happen when running the test manually.
Created attachment 230162 [details] Patch
Created attachment 230170 [details] Try to fix mac and EFL builds
Comment on attachment 230170 [details] Try to fix mac and EFL builds View in context: https://bugs.webkit.org/attachment.cgi?id=230170&action=review GTK+ bits look good to me. > Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1027 > +static bool iframeIsAbovePlugin(const Vector<const RenderObject*>& iframeZIndexStack, const Vector<const RenderObject*>& pluginZIndexStack) > +{ > + for (size_t i = 0; i < iframeZIndexStack.size() && i < pluginZIndexStack.size(); ++i) { > + // The root is at the end of these stacks. We want to iterate root-downwards so we index backwards from the end. > + const RenderObject* iframeStackRootObject = iframeZIndexStack[iframeZIndexStack.size() - 1 - i]; > + const RenderObject* pluginStackRootObject = pluginZIndexStack[pluginZIndexStack.size() - 1 - i]; This requires preserving the original copyright, I think.
Created attachment 230285 [details] Address review comments and try to fix mac build
*** Bug 68969 has been marked as a duplicate of this bug. ***
Comment on attachment 230285 [details] Address review comments and try to fix mac build Marking as r- due to the age of the patch. Could you please update your code against the current source tree and resubmit for review?
Created attachment 274403 [details] Rebased patch
Attachment 274403 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:784: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:786: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp:303: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp:305: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 4 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 274405 [details] Fox coding style
Created attachment 274406 [details] Try to fix mac build
Created attachment 274407 [details] Try to fix mac build
Can we use a region instead of a list of vectors for occlusions?
(In reply to comment #12) > Can we use a region instead of a list of vectors for occlusions? Yes, indeed.
Created attachment 274576 [details] Updated patch to use Region for occlusions
Any other concern about this?
Ping reviewers? This is more than 2 years old now...
Comment on attachment 274576 [details] Updated patch to use Region for occlusions r-, as this has been pending review for over a year now. It is near-impossible that this patch still applies to trunk and unlikely to still be relevant in its current form.
Support for plugins was removed in https://trac.webkit.org/changeset/265753/webkit.
<rdar://problem/96050650>