Bug 132177 – AX: ARIA 1.1: aria-orientation now defaults to undefined, supported on more elements, and role-specific defaults are defined.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[James Craig]

AX: ARIA 1.1: aria-orientation now defaults to undefined, supported on more elements, and role-specific defaults are defined.

http://rawgit.com/w3c/aria/master/spec/aria.html

@aria-orientation is now supported on the following roles (default values per role listed in parens)

- combobox (vertical)
- listbox (vertical)
- menu (vertical)
- menubar (horizontal)
- radiogroup (undefined)
- separator (horizontal)
- scrollbar (vertical)
- tablist (horizontal)
- toolbar (horizontal)
- tree (vertical)
- treegrid (undefined)

[Radar WebKit Bug Importer]

<rdar://problem/16723036>

[Nan Wang]

Created attachment 262534 [details]
patch

[chris fleizach]

Comment on attachment 262534 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262534&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2725
> +    if (isScrollbar()

these seem short enough they could go on one line

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2732
> +    if (isMenuBar()

these seem short enough they could go on one line

> LayoutTests/accessibility/mac/aria-orientation.html:78
> +          shouldBe("slider2.orientation", "'AXOrientation: '");

it seems like we should probably return a value for undefined

[Nan Wang]

Created attachment 262544 [details]
patch

[WebKit Commit Bot]

Comment on attachment 262544 [details]
patch

Clearing flags on attachment: 262544

Committed r190648: <http://trac.webkit.org/changeset/190648>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.