Bug 132176 – [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Joonghun Park]

disable leveldb used for indexedDB in webkit1 of EFL port.

[Joonghun Park]

Created attachment 230150 [details]
Patch

[Ryuan Choi]

Comment on attachment 230150 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230150&action=review

> Source/cmake/OptionsEfl.cmake:295
>  if (ENABLE_INDEXED_DATABASE)
> -    set(WTF_USE_LEVELDB 1)
> -    add_definitions(-DWTF_USE_LEVELDB=1)
> +    set(WTF_USE_LEVELDB 0)
> +    add_definitions(-DWTF_USE_LEVELDB=0)
>  endif ()

Why don't you just remove them.

[Gyuyoung Kim]

Comment on attachment 230150 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230150&action=review

> ChangeLog:9
> +        Disable leveldb used for indexedDB in WEBKIT1 of EFL port.

Useless description because title is same with this comment. Why do you want to disable it ?

[Joonghun Park]

(In reply to comment #2)
> (From update of attachment 230150 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=230150&action=review
> 
> > Source/cmake/OptionsEfl.cmake:295
> >  if (ENABLE_INDEXED_DATABASE)
> > -    set(WTF_USE_LEVELDB 1)
> > -    add_definitions(-DWTF_USE_LEVELDB=1)
> > +    set(WTF_USE_LEVELDB 0)
> > +    add_definitions(-DWTF_USE_LEVELDB=0)
> >  endif ()
> 
> Why don't you just remove them.

In addition to remove the statements above, I would also disable indexedDB because in current status efl port webkit is not using levelDB nor SQlite.

[Joonghun Park]

(In reply to comment #3)
> (From update of attachment 230150 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=230150&action=review
> 
> > ChangeLog:9
> > +        Disable leveldb used for indexedDB in WEBKIT1 of EFL port.
> 
> Useless description because title is same with this comment. Why do you want to disable it ?

I want to remove indexeddb's implemental dependency on leveldb and change indexeddb to use sqlite in WebKit1. It leads to the status in which EFL webkit1 and webkit2 has no implementation of indexeddb currently. So I turn off indexed database feature until we have sqlite implementation for it.

[Joonghun Park]

Created attachment 230278 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 230278 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230278&action=review

LGTM. Please land this patch after adding my suggestion.

> Tools/ChangeLog:7
> +

It would be good if you mention why EFL port remove indexedDB dependency in ChangeLog. For example,

"EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency for now."

[Joonghun Park]

Created attachment 230279 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 230279 [details]
Patch

You don't need to request review again if you already got r+ed.

[Ryuan Choi]

Committed r167872: <http://trac.webkit.org/changeset/167872>