RESOLVED FIXED 132169
Subpixel rendering: Make selection gaps painting subpixel aware. 
https://bugs.webkit.org/show_bug.cgi?id=132169
Summary Subpixel rendering: Make selection gaps painting subpixel aware.
zalan
Reported 2014-04-24 21:53:11 PDT
ssia. patch is coming up.
Attachments
Patch (6.51 KB, patch)
2014-04-24 21:57 PDT, zalan 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (470.73 KB, application/zip)
2014-04-24 23:00 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (497.97 KB, application/zip)
2014-04-24 23:15 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (471.14 KB, application/zip)
2014-04-24 23:58 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (499.62 KB, application/zip)
2014-04-25 00:21 PDT, Build Bot 		no flags
Details
Patch (6.51 KB, patch)
2014-05-01 09:58 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2014-04-24 21:57:14 PDT
Created attachment 230137 [details] Patch
Build Bot
Comment 2 2014-04-24 23:00:50 PDT
Comment on attachment 230137 [details] Patch Attachment 230137 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5713965585793024 New failing tests: fast/inline/hidpi-selection-gap-on-subpixel-position.html
Build Bot
Comment 3 2014-04-24 23:00:57 PDT
Created attachment 230141 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 4 2014-04-24 23:15:37 PDT
Comment on attachment 230137 [details] Patch Attachment 230137 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6120604499443712 New failing tests: fast/inline/hidpi-selection-gap-on-subpixel-position.html
Build Bot
Comment 5 2014-04-24 23:15:41 PDT
Created attachment 230142 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 6 2014-04-24 23:58:08 PDT
Comment on attachment 230137 [details] Patch Attachment 230137 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6466151798276096 New failing tests: fast/inline/hidpi-selection-gap-on-subpixel-position.html
Build Bot
Comment 7 2014-04-24 23:58:11 PDT
Created attachment 230144 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 8 2014-04-25 00:21:36 PDT
Comment on attachment 230137 [details] Patch Attachment 230137 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6497010064556032 New failing tests: fast/inline/hidpi-selection-gap-on-subpixel-position.html
Build Bot
Comment 9 2014-04-25 00:21:40 PDT
Created attachment 230146 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5
zalan
Comment 10 2014-04-25 10:17:59 PDT
This code has dependency on bug 132164. Will check EWS soon after bug 132164 is landed.
Darin Adler
Comment 11 2014-04-29 09:03:31 PDT
Comment on attachment 230137 [details] Patch Looks like the newly-added regression test is failing.
zalan
Comment 12 2014-04-29 09:16:38 PDT
(In reply to comment #11) > (From update of attachment 230137 [details]) > Looks like the newly-added regression test is failing. This code has dependency on bug 132164. Will check with EWS soon after the patch for bug 132164 is landed.
zalan
Comment 13 2014-05-01 09:58:12 PDT
Created attachment 230586 [details] Patch
WebKit Commit Bot
Comment 14 2014-05-01 11:50:08 PDT
Comment on attachment 230586 [details] Patch Clearing flags on attachment: 230586 Committed r168111: <http://trac.webkit.org/changeset/168111>
WebKit Commit Bot
Comment 15 2014-05-01 11:50:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.