Bug 132169 - Subpixel rendering: Make selection gaps painting subpixel aware.
Summary: Subpixel rendering: Make selection gaps painting subpixel aware.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-24 21:53 PDT by zalan
Modified: 2014-05-01 11:50 PDT (History)
7 users (show)

See Also:


Attachments
Patch (6.51 KB, patch)
2014-04-24 21:57 PDT, zalan
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (470.73 KB, application/zip)
2014-04-24 23:00 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (497.97 KB, application/zip)
2014-04-24 23:15 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (471.14 KB, application/zip)
2014-04-24 23:58 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (499.62 KB, application/zip)
2014-04-25 00:21 PDT, Build Bot
no flags Details
Patch (6.51 KB, patch)
2014-05-01 09:58 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-04-24 21:53:11 PDT
ssia. patch is coming up.
Comment 1 zalan 2014-04-24 21:57:14 PDT
Created attachment 230137 [details]
Patch
Comment 2 Build Bot 2014-04-24 23:00:50 PDT
Comment on attachment 230137 [details]
Patch

Attachment 230137 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5713965585793024

New failing tests:
fast/inline/hidpi-selection-gap-on-subpixel-position.html
Comment 3 Build Bot 2014-04-24 23:00:57 PDT
Created attachment 230141 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Build Bot 2014-04-24 23:15:37 PDT
Comment on attachment 230137 [details]
Patch

Attachment 230137 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6120604499443712

New failing tests:
fast/inline/hidpi-selection-gap-on-subpixel-position.html
Comment 5 Build Bot 2014-04-24 23:15:41 PDT
Created attachment 230142 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 6 Build Bot 2014-04-24 23:58:08 PDT
Comment on attachment 230137 [details]
Patch

Attachment 230137 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6466151798276096

New failing tests:
fast/inline/hidpi-selection-gap-on-subpixel-position.html
Comment 7 Build Bot 2014-04-24 23:58:11 PDT
Created attachment 230144 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 8 Build Bot 2014-04-25 00:21:36 PDT
Comment on attachment 230137 [details]
Patch

Attachment 230137 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6497010064556032

New failing tests:
fast/inline/hidpi-selection-gap-on-subpixel-position.html
Comment 9 Build Bot 2014-04-25 00:21:40 PDT
Created attachment 230146 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 10 zalan 2014-04-25 10:17:59 PDT
This code has dependency on bug 132164. Will check EWS soon after bug 132164 is landed.
Comment 11 Darin Adler 2014-04-29 09:03:31 PDT
Comment on attachment 230137 [details]
Patch

Looks like the newly-added regression test is failing.
Comment 12 zalan 2014-04-29 09:16:38 PDT
(In reply to comment #11)
> (From update of attachment 230137 [details])
> Looks like the newly-added regression test is failing.
This code has dependency on bug 132164. Will check with EWS soon after the patch for bug 132164 is landed.
Comment 13 zalan 2014-05-01 09:58:12 PDT
Created attachment 230586 [details]
Patch
Comment 14 WebKit Commit Bot 2014-05-01 11:50:08 PDT
Comment on attachment 230586 [details]
Patch

Clearing flags on attachment: 230586

Committed r168111: <http://trac.webkit.org/changeset/168111>
Comment 15 WebKit Commit Bot 2014-05-01 11:50:13 PDT
All reviewed patches have been landed.  Closing bug.