Bug 132163 - FrameLoader::checkCompleted can hit the "ref'ing while destroyed" assertion
Summary: FrameLoader::checkCompleted can hit the "ref'ing while destroyed" assertion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-24 19:03 PDT by Darin Adler
Modified: 2014-04-24 23:02 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.97 KB, patch)
2014-04-24 19:04 PDT, Darin Adler
beidson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2014-04-24 19:03:01 PDT
FrameLoader::checkCompleted can hit the "ref'ing while destroyed" assertion
Comment 1 Darin Adler 2014-04-24 19:04:58 PDT
Created attachment 230129 [details]
Patch
Comment 2 Darin Adler 2014-04-24 19:05:41 PDT
<rdar://problem/16720640>
Comment 3 Brady Eidson 2014-04-24 20:18:48 PDT
Comment on attachment 230129 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230129&action=review

> Source/WebCore/loader/FrameLoader.cpp:819
> +    // of this function can be called the frame's destructor, and it's not legal

...can be called *in* the frame's destructor..
Comment 4 Darin Adler 2014-04-24 23:01:58 PDT
Committed r167790: <http://trac.webkit.org/changeset/167790>