Bug 132151 - Mark Supplement instead of RefCountedSupplement in NavigatorContentUtils
Summary: Mark Supplement instead of RefCountedSupplement in NavigatorContentUtils
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-24 15:35 PDT by Gyuyoung Kim
Modified: 2014-04-24 21:00 PDT (History)
1 user (show)

See Also:


Attachments
Patch (4.37 KB, patch)
2014-04-24 15:47 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-04-24 15:35:05 PDT
Though NavigatorContentUtils didn't have any scenario which can be shared across navigator instances, it has used RefCountedSupplement. So, we need to use Supplement<Page> instead of RefCountedSupplement<>.
Comment 1 Gyuyoung Kim 2014-04-24 15:39:23 PDT
(In reply to comment #0)
> Though NavigatorContentUtils didn't have any scenario which can be shared across navigator instances, it has used RefCountedSupplement. So, we need to use Supplement<Page> instead of RefCountedSupplement<>.

s/across navigator instances/across page instances/g


It was considered to make the NavigatorContentUtils shareable across navigator instances. However, it has used RefCountedSupplement<Page> instead of RefCountedSupplement<Navigator>.
Comment 2 Gyuyoung Kim 2014-04-24 15:47:22 PDT
Created attachment 230114 [details]
Patch
Comment 3 Darin Adler 2014-04-24 17:14:21 PDT
Comment on attachment 230114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230114&action=review

> Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.h:58
> +    static PassOwnPtr<NavigatorContentUtils> create(std::unique_ptr<NavigatorContentUtilsClient>);

Should use std::unique_ptr, not PassOwnPtr, in new code. But I guess we need to fix all Supplement implementers at once.
Comment 4 Gyuyoung Kim 2014-04-24 20:31:57 PDT
(In reply to comment #3)
> (From update of attachment 230114 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=230114&action=review
> 
> > Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.h:58
> > +    static PassOwnPtr<NavigatorContentUtils> create(std::unique_ptr<NavigatorContentUtilsClient>);
> 
> Should use std::unique_ptr, not PassOwnPtr, in new code. But I guess we need to fix all Supplement implementers at once.

Yes, I also wanna to it at once. I'm gonna file a bug for it.
Comment 5 WebKit Commit Bot 2014-04-24 21:00:14 PDT
Comment on attachment 230114 [details]
Patch

Clearing flags on attachment: 230114

Committed r167789: <http://trac.webkit.org/changeset/167789>
Comment 6 WebKit Commit Bot 2014-04-24 21:00:19 PDT
All reviewed patches have been landed.  Closing bug.