WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
132149
Web Inspector: CodeMirror 4 CSS mode new state data structure breaks helpers.
https://bugs.webkit.org/show_bug.cgi?id=132149
Summary
Web Inspector: CodeMirror 4 CSS mode new state data structure breaks helpers.
Jonathan Wells
Reported
2014-04-24 15:20:11 PDT
CSS mode has done away with state.stack to track the mode hierarchy and instead uses a linked object structure. Pretty Printing and other CodeMirror helpers/addons are broken as a result and need to be updated for the new structure.
Attachments
[PATCH] Proposed Fix: Change to CodeMirror controllers and additions.
(20.09 KB, patch)
2014-05-01 19:31 PDT
,
Jonathan Wells
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2014-04-24 15:21:06 PDT
<
rdar://problem/16718309
>
Jonathan Wells
Comment 2
2014-05-01 19:31:00 PDT
Created
attachment 230645
[details]
[PATCH] Proposed Fix: Change to CodeMirror controllers and additions. Carefully went through and changed references to tokens and states appropriately.
Timothy Hatcher
Comment 3
2014-05-01 19:53:05 PDT
Looks good to me. I'd like Joe to take a look too.
Joseph Pecoraro
Comment 4
2014-05-02 08:33:33 PDT
Comment on
attachment 230645
[details]
[PATCH] Proposed Fix: Change to CodeMirror controllers and additions. Looks good to me
WebKit Commit Bot
Comment 5
2014-05-02 09:04:38 PDT
Comment on
attachment 230645
[details]
[PATCH] Proposed Fix: Change to CodeMirror controllers and additions. Clearing flags on attachment: 230645 Committed
r168170
: <
http://trac.webkit.org/changeset/168170
>
WebKit Commit Bot
Comment 6
2014-05-02 09:04:41 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug