Bug 132147 - REGRESSION: Apparent hang of PCE.js Mac OS System 7.0.1 on ARM64 devices
Summary: REGRESSION: Apparent hang of PCE.js Mac OS System 7.0.1 on ARM64 devices
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-24 15:15 PDT by Michael Saboff
Modified: 2014-04-24 17:14 PDT (History)
0 users

See Also:

Attachments
Patch (2.09 KB, patch)
2014-04-24 15:20 PDT, Michael Saboff 		mhahnenberg: review+
Details | Formatted Diff | Diff
Patch with test added (2.89 KB, patch)
2014-04-24 16:56 PDT, Michael Saboff 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2014-04-24 15:15:18 PDT 
This is fundamentally an 68K instruction emulator.  Tracked the issue to MacroAssemblerARM64.h where we inadvertently use the destination register for both the source and destination in two arg or64(),  eor32( ) and eor64().
Comment 1 Michael Saboff 2014-04-24 15:20:29 PDT 
Created attachment 230111 [details]
Patch
Comment 2 Mark Hahnenberg 2014-04-24 15:22:52 PDT 
Comment on attachment 230111 [details]
Patch

r=me. Is it possible to write a test?
Comment 3 Michael Saboff 2014-04-24 15:42:51 PDT 
(In reply to comment #2)
> (From update of attachment 230111 [details])
> r=me. Is it possible to write a test?

I think so.  I'll spend some time to see if I can come up with one.
Comment 4 Michael Saboff 2014-04-24 16:56:44 PDT 
Created attachment 230118 [details]
Patch with test added
Comment 5 Mark Lam 2014-04-24 17:04:03 PDT 
Comment on attachment 230118 [details]
Patch with test added

r=me
Comment 6 Michael Saboff 2014-04-24 17:14:46 PDT 
Committed r167782: <http://trac.webkit.org/changeset/167782>