Bug 132118 – [EFL] WebKit build fails when MEDIA_SOURCE is enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Praveen Jadhav]

Enable MEDIA_SOURCE for EFL build in the file Tools/Scripts/webkitperl/FeatureList.pm and compile the code. Build breaks with the following error.

CMakeFiles/WebCore.dir/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp.o: In function `WebCore::initializeGStreamerAndRegisterWebKitElements()':
MediaPlayerPrivateGStreamer.cpp:(.text._ZN7WebCore44initializeGStreamerAndRegisterWebKitElementsEv+0xc1): undefined reference to `webkit_media_src_get_type'
CMakeFiles/WebCore.dir/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp.o: In function `WebCore::MediaPlayerPrivateGStreamer::sourceChanged()':
MediaPlayerPrivateGStreamer.cpp:(.text._ZN7WebCore27MediaPlayerPrivateGStreamer13sourceChangedEv+0x8c): undefined reference to `webkit_media_src_get_type'
MediaPlayerPrivateGStreamer.cpp:(.text._ZN7WebCore27MediaPlayerPrivateGStreamer13sourceChangedEv+0xc1): undefined reference to `webkit_media_src_get_type'
MediaPlayerPrivateGStreamer.cpp:(.text._ZN7WebCore27MediaPlayerPrivateGStreamer13sourceChangedEv+0xdf): undefined reference to `WebCore::MediaSourceGStreamer::open(WebCore::MediaSourcePrivateClient*, _WebKitMediaSrc*)'
MediaPlayerPrivateGStreamer.cpp:(.text._ZN7WebCore27MediaPlayerPrivateGStreamer13sourceChangedEv+0xeb): undefined reference to `webkit_media_src_get_type'
MediaPlayerPrivateGStreamer.cpp:(.text._ZN7WebCore27MediaPlayerPrivateGStreamer13sourceChangedEv+0x109): undefined reference to `webKitMediaSrcSetPlayBin'
collect2: error: ld returned 1 exit status
make[2]: *** [lib/libwebcore_efl.so.0.1.0] Error 1
make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2
make: *** [all] Error 2

[Praveen Jadhav]

Created attachment 230066 [details]
Patch

PlatformEfl.cmake is modified to include MediaSourceGStreamer.cpp, SourceBufferPrivateGStreamer.cpp and WebKitMediaSourceGStreamer.cpp for compilation.

[Gyuyoung Kim]

Comment on attachment 230066 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230066&action=review

It would be nice to move those file from PlatofrmGTK|EFL to CMakeLists.txt because GTK port also use it. However, we can't do that because wince port doesn't use it.

> Source/WebCore/CMakeLists.txt:3111
> +    "${WEBCORE_DIR}/platform/mock/mediasource"

PlatformGTK.cmake also includes this path. I think you need to remove it from the PlatformGTK.cmake if you want to add the path to CMakeLists.txt But, wince port doesn't need to include this path. So, I think you need to move this to PlatformEfl.cmake as well.

[Praveen Jadhav]

Created attachment 230074 [details]
Patch

Patch updated. All changes are included in PlatformEfl.cmake to ensure other bots are not affected.

[Brent Fulgham]

Comment on attachment 230074 [details]
Patch

r=me. Are similar changes needed on Gtk?

[WebKit Commit Bot]

Comment on attachment 230074 [details]
Patch

Clearing flags on attachment: 230074

Committed r167762: <http://trac.webkit.org/changeset/167762>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Praveen Jadhav]

(In reply to comment #4)
> (From update of attachment 230074 [details])
> r=me. Are similar changes needed on Gtk?

Gtk already has these changes.