Bug 132114 - WebKit2 View Gestures: Use a single struct for the snapshot, and pass it around
Summary: WebKit2 View Gestures: Use a single struct for the snapshot, and pass it around
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-24 01:35 PDT by Tim Horton
Modified: 2014-04-24 14:46 PDT (History)
1 user (show)

See Also:


Attachments
patch (12.86 KB, patch)
2014-04-24 13:54 PDT, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-04-24 01:35:02 PDT
So that we can persist a few other interesting properties, for future changes.
Comment 1 Tim Horton 2014-04-24 13:54:41 PDT
Created attachment 230100 [details]
patch
Comment 2 Simon Fraser (smfr) 2014-04-24 14:19:40 PDT
Comment on attachment 230100 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230100&action=review

> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:89
> +#if USE(IOSURFACE)
> +        if (!snapshot->value.surface)
> +            continue;
> +#else
> +        if (!snapshot->value.image)
> +            continue;
> +#endif

Put in a member function on Snapshot?

> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:101
> +#if USE(IOSURFACE)
> +        snapshot->value.surface = nullptr;
> +#else
> +        snapshot->value.image = nullptr;
> +#endif

Put in a member function on Snapshot?

> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:122
> +#if USE(IOSURFACE)
> +    snapshot->value.surface = nullptr;
> +#else
> +    snapshot->value.image = nullptr;
> +#endif

Call said member function?
Comment 3 Tim Horton 2014-04-24 14:46:39 PDT
http://trac.webkit.org/changeset/167775