Bug 132110 - FontCache::fontCache() never returns nullptr so it can be made to return a reference instead
Summary: FontCache::fontCache() never returns nullptr so it can be made to return a re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-24 00:02 PDT by Myles C. Maxfield
Modified: 2014-04-24 12:06 PDT (History)
15 users (show)

See Also:

Attachments
Patch (33.67 KB, patch)
2014-04-24 00:05 PDT, Myles C. Maxfield 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-04-24 00:02:26 PDT 
FontCache::fontCache() never returns nullptr so it can be made to return a reference instead
Comment 1 Myles C. Maxfield 2014-04-24 00:05:41 PDT 
Created attachment 230054 [details]
Patch
Comment 2 Tim Horton 2014-04-24 00:38:06 PDT 
Comment on attachment 230054 [details]
Patch

Nice! Did you make sure that iOS build doesn't break too? (seems like you're probably safe)
Comment 3 Myles C. Maxfield 2014-04-24 12:04:02 PDT 
Yep! iOS builds fine.
Comment 4 Myles C. Maxfield 2014-04-24 12:06:41 PDT 
http://trac.webkit.org/changeset/167768