[Cocoa] fix CF leaks found by code inspection
Created attachment 230044 [details] Patch
Comment on attachment 230044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230044&action=review r=me. Nice finds! > Source/WebCore/plugins/mac/PluginPackageMac.cpp:138 > + RetainPtr<CFStringRef> homeDir = adoptCF(homeDirectoryPath().createCFString()); We don't need adoptCF() here; createCFString() returns a RetainPtr<CFStringRef>. > Source/WebCore/plugins/mac/PluginPackageMac.cpp:255 > + RetainPtr<CFStringRef> path = adoptCF(m_path.createCFString()); Ditto.
Committed r167746: <http://trac.webkit.org/changeset/167746>
Comment on attachment 230044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230044&action=review >> Source/WebCore/plugins/mac/PluginPackageMac.cpp:138 >> + RetainPtr<CFStringRef> homeDir = adoptCF(homeDirectoryPath().createCFString()); > > We don't need adoptCF() here; createCFString() returns a RetainPtr<CFStringRef>. Not even sure how this compiles.
*** Bug 132108 has been marked as a duplicate of this bug. ***