Bug 132092 - [wk2] Provide SPI allowing clients to hand events directly to swipe code, bypassing scrolling
Summary: [wk2] Provide SPI allowing clients to hand events directly to swipe code, byp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-23 18:02 PDT by Tim Horton
Modified: 2014-04-24 10:49 PDT (History)
2 users (show)

See Also:

Attachments
patch (7.57 KB, patch)
2014-04-23 18:07 PDT, Tim Horton 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-04-23 18:02:15 PDT 
Some clients may want to allow swipes in another view to swipe the WKView regardless of the content of the WKView (so, bypassing normal scrolling). For example, a full-view overlay that displays totally different (but related) content.
Comment 1 Tim Horton 2014-04-23 18:07:32 PDT 
Created attachment 230026 [details]
patch
Comment 2 Darin Adler 2014-04-24 09:16:17 PDT 
Comment on attachment 230026 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230026&action=review

> Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:106
> +    , m_ignorePinnedState(false)

We try to have these be adjective phrases instead of verb phrases. That’s why the name will often be something like m_shouldIgnorePinnedState.
Comment 3 Tim Horton 2014-04-24 10:49:34 PDT 
http://trac.webkit.org/changeset/167766