Bug 132053 – [Mac] REGRESSION (r164823): Building JavaScriptCore creates files under /tmp/JavaScriptCore.dst

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

http://trac.webkit.org/changeset/164823
http://trac.webkit.org/changeset/164828

After this change build-jsc unconditionally tries to remove and 
recreate a symlink to /tmp/JavaScriptCore.dst/usr/local/bin:
jsc -> ../../../System/Library/Frameworks/JavaScriptCore.framework/Versions/A/Resources/jsc

Additionally this symlink is broken, it points to a non-existent path.

If there are more user work on a Mac, the second user won't be able 
to remove and recreate this symlink and build-jsc will fail.

Could you possibly give us some hint how can we solve this problem?

[Csaba Osztrogonác]

Created attachment 229969 [details]
Patch

I propose to revert r164823 and r164828, because now build-webkit always try to remove and recreate a broken and useless symlink unconditionally. It is a huge regression that now only one user can build WebKit on a Mac.

[Mark Rowe (bdash)]

Comment on attachment 229969 [details]
Patch

Rolling those changes out reintroduces a much more serious issue. This should be trivial to fix properly, so let's just do that instead.

[Csaba Osztrogonác]

(In reply to comment #2)
> (From update of attachment 229969 [details])
> Rolling those changes out reintroduces a much more serious issue. This should be trivial to fix properly, so let's just do that instead.

Could you give us any hint how can it be fixed properly?

[Mark Rowe (bdash)]

Created attachment 229970 [details]
Patch

[Mark Rowe (bdash)]

Created attachment 229971 [details]
Patch

[Csaba Osztrogonác]

(In reply to comment #5)
> Created an attachment (id=229971) [details]
> Patch

Thanks for the patch, it fixes the multi user issue I mentioned
in the description. But I don't have expertise in Mac deployment,
I let others to review the fix.

[WebKit Commit Bot]

Comment on attachment 229971 [details]
Patch

Clearing flags on attachment: 229971

Committed r167709: <http://trac.webkit.org/changeset/167709>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.