Bug 132050 - [CSS Regions] Rename objectShouldPaintInFlowRegion to something more clear
Summary: [CSS Regions] Rename objectShouldPaintInFlowRegion to something more clear
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Radu Stavila
URL:
Keywords: AdobeTracked
Depends on:
Blocks: 57312
  Show dependency tree / graph
 
Reported: 2014-04-23 01:45 PDT by Radu Stavila
Modified: 2014-04-25 10:58 PDT (History)
6 users (show)

See Also:

Attachments
Patch (8.08 KB, patch)
2014-04-25 08:22 PDT, Radu Stavila 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Radu Stavila 2014-04-23 01:45:34 PDT 
Rename objectShouldPaintInFlowRegion to something more clear as its no longer used just for painting, but also for hit-testing and other tasks.
Comment 1 Radu Stavila 2014-04-25 08:22:58 PDT 
Created attachment 230180 [details]
Patch
Comment 2 Andreas Kling 2014-04-25 09:04:31 PDT 
Comment on attachment 230180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230180&action=review

r=me

> Source/WebCore/rendering/RenderFlowThread.cpp:810
> +bool RenderFlowThread::objectShouldFragmentInFlowRegion(const RenderObject* object, const RenderRegion* region) const
>  {
>      ASSERT(object);
>      ASSERT(region);

The two ASSERTs here indicate that the arguments should really be references instead of pointers.
That kind of change does not belong in this patch though.
Comment 3 WebKit Commit Bot 2014-04-25 10:58:48 PDT 
Comment on attachment 230180 [details]
Patch

Clearing flags on attachment: 230180

Committed r167810: <http://trac.webkit.org/changeset/167810>
Comment 4 WebKit Commit Bot 2014-04-25 10:58:51 PDT 
All reviewed patches have been landed.  Closing bug.