Bug 132044 - [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
Summary: [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Regression
Depends on:
Blocks:
 
Reported: 2014-04-23 00:55 PDT by Carlos Garcia Campos
Modified: 2014-10-21 00:32 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.30 KB, patch)
2014-10-14 02:13 PDT, Carlos Garcia Campos
burg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-04-23 00:55:52 PDT
TEST: WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestInspectorServer... (pid=30953)
**
ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:241:void openRemoteDebuggingSession(InspectorServerTest*, gconstpointer): assertion failed: (javascriptResult)
GTester: last random seed: R02S76a375c7b7e9a9fb04f17fded1d0cf78
(pid=31125)
FAIL: WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestInspectorServer
Tests failed (1): WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestInspectorServer
Comment 1 Philippe Normand 2014-05-27 06:22:26 PDT
I'm starting a patch.
Comment 2 Carlos Garcia Campos 2014-10-02 06:35:36 PDT
I think one of the problems is that in r164543 the order of the scripts in Main.html changed. One of the problems I see in the console is:

ReferenceError: Can't find variable: InspectorFrontendHost

That happens in Platform.js, because InspectorFrontendHostStub.js hasn't been loaded yet. With the local inspector doesn't happen because the InspectorFrontendHost is injected directly from the code on window object cleared. There might be more errors like this, I also see 'IndexedDB' domain was not found, not sure that was if fatal, though.
Comment 3 Carlos Garcia Campos 2014-10-14 02:13:14 PDT
Created attachment 239787 [details]
Patch

The inspector still doesn't work because of bug #137340, but reverting r174025 and applying this patch makes the remote inspector work again and the test to pass.
Comment 4 Brian Burg 2014-10-20 10:45:07 PDT
(In reply to comment #2)
> I think one of the problems is that in r164543 the order of the scripts in
> Main.html changed. One of the problems I see in the console is:
> 
> ReferenceError: Can't find variable: InspectorFrontendHost
> 
> That happens in Platform.js, because InspectorFrontendHostStub.js hasn't
> been loaded yet. With the local inspector doesn't happen because the
> InspectorFrontendHost is injected directly from the code on window object
> cleared. There might be more errors like this, I also see 'IndexedDB' domain
> was not found, not sure that was if fatal, though.

It should be able to fail cleanly with no IndexedDB domain, since it's an optional feature. If the inspector or tests break with !ENABLE(INDEXED_DATABASE) please file a bug.
Comment 5 Carlos Garcia Campos 2014-10-21 00:32:34 PDT
Committed r174926: <http://trac.webkit.org/changeset/174926>