Bug 132039 - [EFL][WK1] There are many failures in fast/forms since r163033
Summary: [EFL][WK1] There are many failures in fast/forms since r163033
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-22 22:02 PDT by Ryuan Choi
Modified: 2014-04-22 22:34 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.95 KB, patch)
2014-04-22 22:05 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2014-04-22 22:02:22 PDT 
SSIA
Comment 1 Ryuan Choi 2014-04-22 22:05:02 PDT 
Created attachment 229954 [details]
Patch
Comment 2 Gyuyoung Kim 2014-04-22 22:12:05 PDT 
Comment on attachment 229954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229954&action=review

LGTM

> Source/WebKit/efl/ewk/ewk_view.cpp:3686
> +        break;

Additionally, I think we need to add ASSERT_NOT_REACHED() when user passes unsupported type.

    default:
        ASSERT_NOT_REACHED();
        break;
Comment 3 Ryuan Choi 2014-04-22 22:29:10 PDT 
Committed r167697: <http://trac.webkit.org/changeset/167697>
Comment 4 Ryuan Choi 2014-04-22 22:34:45 PDT 
Comment on attachment 229954 [details]
Patch

clearing flags. landed with gyuyoung's suggestion