Bug 132029 - DumpRenderTree generates black snapshots on some platforms
Summary: DumpRenderTree generates black snapshots on some platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-22 16:37 PDT by Tim Horton
Modified: 2014-04-22 16:55 PDT (History)
4 users (show)

See Also:

Attachments
patch (1.93 KB, patch)
2014-04-22 16:42 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-04-22 16:37:48 PDT 
DRT checks with the WebView to determine whether it can use the window's backing store directly or (because of compositing) needs to take a WindowServer snapshot. However, on some platforms and in some situations, the window can be layer backed without the WebView necessarily currently being composited. We should check with the window in addition to the WebView before going ahead and using its backing store.

<rdar://problem/16679363>
Comment 1 Tim Horton 2014-04-22 16:42:43 PDT 
Created attachment 229924 [details]
patch
Comment 2 Tim Horton 2014-04-22 16:55:57 PDT 
http://trac.webkit.org/changeset/167691