Bug 132027 - Remove BackForwardController::client() and its uses
Summary: Remove BackForwardController::client() and its uses
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: History (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 131637
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-22 15:56 PDT by Brian Burg
Modified: 2015-08-03 19:58 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-04-22 15:56:27 PDT 
We should not be getting the client pointer and casting to a subclass, as is done in several places. Many of these uses can be converted to calls on BackForwardController.

For other calls, if code in WK/WK2 needs to use a concrete subclass of BackForwardClient, then it should store a pointer to the subclass instance and pass it to WebCore using PageClients.