Bug 132014 - Add SPI to expose provisional and committed URL from Frame.
Summary: Add SPI to expose provisional and committed URL from Frame.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-22 10:45 PDT by Yongjun Zhang
Modified: 2014-04-22 23:00 PDT (History)
4 users (show)

See Also:

Attachments
Patch. (2.83 KB, patch)
2014-04-22 10:50 PDT, Yongjun Zhang 		mitz: review+
Details | Formatted Diff | Diff
Remove _committedURL from the previous patch before landing. (2.54 KB, patch)
2014-04-22 22:24 PDT, Yongjun Zhang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yongjun Zhang 2014-04-22 10:45:55 PDT 
It would be nice to expose the provisional URL and committed URL from WKWebProcessPlugInFrame.
Comment 1 Yongjun Zhang 2014-04-22 10:50:22 PDT 
Created attachment 229896 [details]
Patch.
Comment 2 mitz 2014-04-22 14:13:12 PDT 
Comment on attachment 229896 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=229896&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h:41
> +@property (nonatomic, readonly) NSURL *_committedURL;

This is already exposed via the URL property. Other than that, looks good.
Comment 3 mitz 2014-04-22 14:13:49 PDT 
Comment on attachment 229896 [details]
Patch.

r=me on the _provisionalURL part.
Comment 4 Yongjun Zhang 2014-04-22 14:18:02 PDT 
(In reply to comment #3)
> (From update of attachment 229896 [details])
> r=me on the _provisionalURL part.
aha, I somehow missed URL.  Will remove _committedURL.  thanks!
Comment 5 Yongjun Zhang 2014-04-22 22:24:41 PDT 
Created attachment 229956 [details]
Remove _committedURL from the previous patch before landing.
Comment 6 WebKit Commit Bot 2014-04-22 23:00:02 PDT 
Comment on attachment 229956 [details]
Remove _committedURL from the previous patch before landing.

Clearing flags on attachment: 229956

Committed r167699: <http://trac.webkit.org/changeset/167699>
Comment 7 WebKit Commit Bot 2014-04-22 23:00:05 PDT 
All reviewed patches have been landed.  Closing bug.