RESOLVED FIXED 132014
Add SPI to expose provisional and committed URL from Frame.
https://bugs.webkit.org/show_bug.cgi?id=132014
Summary Add SPI to expose provisional and committed URL from Frame.
Yongjun Zhang
Reported 2014-04-22 10:45:55 PDT
It would be nice to expose the provisional URL and committed URL from WKWebProcessPlugInFrame.
Attachments
Patch. (2.83 KB, patch)
2014-04-22 10:50 PDT, Yongjun Zhang
mitz: review+
Remove _committedURL from the previous patch before landing. (2.54 KB, patch)
2014-04-22 22:24 PDT, Yongjun Zhang
no flags
Yongjun Zhang
Comment 1 2014-04-22 10:50:22 PDT
mitz
Comment 2 2014-04-22 14:13:12 PDT
Comment on attachment 229896 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=229896&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h:41 > +@property (nonatomic, readonly) NSURL *_committedURL; This is already exposed via the URL property. Other than that, looks good.
mitz
Comment 3 2014-04-22 14:13:49 PDT
Comment on attachment 229896 [details] Patch. r=me on the _provisionalURL part.
Yongjun Zhang
Comment 4 2014-04-22 14:18:02 PDT
(In reply to comment #3) > (From update of attachment 229896 [details]) > r=me on the _provisionalURL part. aha, I somehow missed URL. Will remove _committedURL. thanks!
Yongjun Zhang
Comment 5 2014-04-22 22:24:41 PDT
Created attachment 229956 [details] Remove _committedURL from the previous patch before landing.
WebKit Commit Bot
Comment 6 2014-04-22 23:00:02 PDT
Comment on attachment 229956 [details] Remove _committedURL from the previous patch before landing. Clearing flags on attachment: 229956 Committed r167699: <http://trac.webkit.org/changeset/167699>
WebKit Commit Bot
Comment 7 2014-04-22 23:00:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.