Bug 131983 - [GTK] Crash after getting web view context property with g_object_get
Summary: [GTK] Crash after getting web view context property with g_object_get
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2014-04-22 05:07 PDT by Carlos Garcia Campos
Modified: 2014-04-22 06:36 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2014-04-22 05:09 PDT, Carlos Garcia Campos 		pnormand: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-04-22 05:07:17 PDT 
The problem is that the getter is using g_value_take_object() and the default context is destroyed when the caller releases its ref. We should use g_value_set_object instead.
Comment 1 Carlos Garcia Campos 2014-04-22 05:09:12 PDT 
Created attachment 229875 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-22 05:10:51 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2014-04-22 06:36:55 PDT 
Committed r167656: <http://trac.webkit.org/changeset/167656>