Buildfix after r167650 broke non-Cocoa builds
Created attachment 229873 [details] patch #ifdef-ed out the Mac specific line to fix the non-Cocoa builds.
Comment on attachment 229873 [details] patch Sounds good to me, although we should let bfulgham now about it anyway
Comment on attachment 229873 [details] patch Rejecting attachment 229873 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 229873, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 131980. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.appspot.com/results/4802375017562112
Comment on attachment 229873 [details] patch Missing ChangeLog, prepare-ChangeLog can help with that.
(In reply to comment #4) > (From update of attachment 229873 [details]) > Missing ChangeLog, prepare-ChangeLog can help with that. Opps, that's right. Sorry for my quick review
(In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 229873 [details] [details]) > > Missing ChangeLog, prepare-ChangeLog can help with that. > > Opps, that's right. Sorry for my quick review Sorry, added the ChangeLog and landed patch in r167654.