Bug 131967 – [OS X] Glyph spacing for system fonts may be incorrect

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[OS X] Glyph spacing for system fonts may be incorrect

[Myles C. Maxfield]

Created attachment 229852 [details]
Patch

[WebKit Commit Bot]

Attachment 229852 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:376:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Myles C. Maxfield]

<rdar://problem/16559521>

[Myles C. Maxfield]

Style check is a false negative, though I don't think it's feasible to fix the checker scripts because there are preprocessor macros at play here.

[Dean Jackson]

Comment on attachment 229852 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229852&action=review

> Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:378
> +    if (
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
> +            !CTFontDescriptorIsSystemUIFont(descriptor.get()) &&
> +#endif
> +            (horizontal || m_isBrokenIdeographFallback)) {

I don't know the performance implications, but could you switch to have the ALWAYS test first? That will make the style bot happy.

[Myles C. Maxfield]

Created attachment 229907 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 229907 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229907&action=review

> Source/WebCore/ChangeLog:11
> +        (WebCore::SimpleFontData::platformWidthForGlyph): Update to use CTFontGetAdvancesForGlyphs() for system fonts

You don't explain the horizontal ? kCTFontHorizontalOrientation : kCTFontVerticalOrientation change.

> Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:384
> +    if ((horizontal || m_isBrokenIdeographFallback) && !hasCustomTracking(m_platformData.ctFont())) {

So much better!

[Myles C. Maxfield]

http://trac.webkit.org/changeset/167679

[Myles C. Maxfield]

Reopening to attach new patch.

[Myles C. Maxfield]

Created attachment 229912 [details]
Patch