Bug 131940 - Move the JSString cache from DOMWrapperWorld to VM.
Summary: Move the JSString cache from DOMWrapperWorld to VM.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-21 11:45 PDT by Andreas Kling
Modified: 2014-04-21 12:18 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.95 KB, patch)
2014-04-21 11:52 PDT, Andreas Kling
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-04-21 11:45:59 PDT
There's no need for the string cache to sit on the DOMWrapperWorld. The indirection to get there is pretty expensive, too.
Comment 1 Andreas Kling 2014-04-21 11:52:41 PDT
Created attachment 229816 [details]
Patch
Comment 2 Geoffrey Garen 2014-04-21 12:12:25 PDT
Comment on attachment 229816 [details]
Patch

r=me

Should probably move jsStringWithCache into JSC now -- maybe JSString.h? -- since the library that supplies the data structure might as well supply the function to access it.
Comment 3 Andreas Kling 2014-04-21 12:17:50 PDT
Committed r167605: <http://trac.webkit.org/changeset/167605>
Comment 4 Andreas Kling 2014-04-21 12:18:36 PDT
(In reply to comment #2)
> (From update of attachment 229816 [details])
> r=me
> 
> Should probably move jsStringWithCache into JSC now -- maybe JSString.h? -- since the library that supplies the data structure might as well supply the function to access it.

Oh yeah, okay.