Bug 131939 – Page::setDefersLoading doesn’t do anything when using the Network process

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

<rdar://problem/16631323>

When using the Network process, calling Page::setDefersLoading(true) doesn’t defer loading.

Created attachment 229814 [details]
Add load deferring to NetworkResourceLoader

[David Kilzer (:ddkilzer)]

Comment on attachment 229814 [details]
Add load deferring to NetworkResourceLoader

View in context: https://bugs.webkit.org/attachment.cgi?id=229814&action=review

Darin says:
'''
The patch looks exactly right to me.
'''

Maciej says:
'''
Taking Darin's comment as an r+ and moving to Prepare.
'''

> Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:151
> +        m_request = m_deferredRequest;
> +        m_deferredRequest = ResourceRequest();

Darin says:
'''
We’d get better efficiency if we added a move assignment operator to ResourceRequest and used it there.
'''

[WebKit Commit Bot]

Comment on attachment 229814 [details]
Add load deferring to NetworkResourceLoader

Clearing flags on attachment: 229814

Committed r167635: <http://trac.webkit.org/changeset/167635>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

This was kind of intentional…

What is the guarantee that calling setDefersLoading(true) provides now?