Bug 131939 - Page::setDefersLoading doesn’t do anything when using the Network process
Summary: Page::setDefersLoading doesn’t do anything when using the Network process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-21 11:21 PDT by mitz
Modified: 2014-04-22 12:36 PDT (History)
5 users (show)

See Also:

Attachments
Add load deferring to NetworkResourceLoader (15.69 KB, patch)
2014-04-21 11:32 PDT, mitz 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-04-21 11:21:24 PDT 
<rdar://problem/16631323>

When using the Network process, calling Page::setDefersLoading(true) doesn’t defer loading.
Comment 1 mitz 2014-04-21 11:32:37 PDT 
Created attachment 229814 [details]
Add load deferring to NetworkResourceLoader
Comment 2 David Kilzer (:ddkilzer) 2014-04-21 16:20:38 PDT 
Comment on attachment 229814 [details]
Add load deferring to NetworkResourceLoader

View in context: https://bugs.webkit.org/attachment.cgi?id=229814&action=review

Darin says:
'''
The patch looks exactly right to me.
'''

Maciej says:
'''
Taking Darin's comment as an r+ and moving to Prepare.
'''

> Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:151
> +        m_request = m_deferredRequest;
> +        m_deferredRequest = ResourceRequest();

Darin says:
'''
We’d get better efficiency if we added a move assignment operator to ResourceRequest and used it there.
'''
Comment 3 WebKit Commit Bot 2014-04-21 17:11:06 PDT 
Comment on attachment 229814 [details]
Add load deferring to NetworkResourceLoader

Clearing flags on attachment: 229814

Committed r167635: <http://trac.webkit.org/changeset/167635>
Comment 4 WebKit Commit Bot 2014-04-21 17:11:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2014-04-22 12:36:10 PDT 
This was kind of intentional…

What is the guarantee that calling setDefersLoading(true) provides now?