Bug 131936 - http/tests/cache/subresource-failover-to-network.html is flaky
Summary: http/tests/cache/subresource-failover-to-network.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-21 10:59 PDT by Alexey Proskuryakov
Modified: 2014-04-21 11:55 PDT (History)
1 user (show)

See Also:

Attachments
proposed fix (3.91 KB, patch)
2014-04-21 11:05 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-04-21 10:59:33 PDT 
http/tests/cache/subresource-failover-to-network.html is buggy. It tries to use testRunner queueing, but what actually happens is:

- on first load, the test queues JS execution to submit a form, plus two history navigations.
- but when it navigates back to main page, the same script runs again, queuing the same sequence again!

And then it's nothing but pure luck that makes the test test pass on some platforms.

Also, the test sets a cookie and doesn't reset it, which is sad.
Comment 1 Alexey Proskuryakov 2014-04-21 11:05:50 PDT 
Created attachment 229810 [details]
proposed fix
Comment 2 WebKit Commit Bot 2014-04-21 11:55:41 PDT 
Comment on attachment 229810 [details]
proposed fix

Clearing flags on attachment: 229810

Committed r167601: <http://trac.webkit.org/changeset/167601>
Comment 3 WebKit Commit Bot 2014-04-21 11:55:43 PDT 
All reviewed patches have been landed.  Closing bug.