Bug 131930 - REGRESSION (r160908): Safari doesn't draw rotated images properly first time
Summary: REGRESSION (r160908): Safari doesn't draw rotated images properly first time
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-21 00:25 PDT by Darin Adler
Modified: 2014-04-21 11:09 PDT (History)
11 users (show)

See Also:

Attachments
Patch (18.85 KB, patch)
2014-04-21 00:32 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (465.07 KB, application/zip)
2014-04-21 01:20 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (498.89 KB, application/zip)
2014-04-21 01:53 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (527.84 KB, application/zip)
2014-04-21 02:48 PDT, Build Bot 		no flags Details
Patch (406.50 KB, patch)
2014-04-21 10:37 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (28.30 KB, patch)
2014-04-21 10:41 PDT, Darin Adler 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2014-04-21 00:25:02 PDT 
ImageDocument needs to explicitly updateStyleIfNeeded before looking at renderers
Comment 1 Darin Adler 2014-04-21 00:25:54 PDT 
<rdar://problem/16345245>
Comment 2 Darin Adler 2014-04-21 00:32:38 PDT 
Created attachment 229792 [details]
Patch
Comment 3 Andreas Kling 2014-04-21 01:14:31 PDT 
Regressions: Unexpected text-only failures (2)
  fast/images/favicon-as-image.html [ Failure ]
  http/tests/misc/favicon-as-image.html [ Failure ]
Comment 4 Build Bot 2014-04-21 01:20:50 PDT 
Comment on attachment 229792 [details]
Patch

Attachment 229792 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6715599019311104

New failing tests:
http/tests/misc/favicon-as-image.html
fast/images/favicon-as-image.html
Comment 5 Build Bot 2014-04-21 01:20:54 PDT 
Created attachment 229793 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 Build Bot 2014-04-21 01:53:09 PDT 
Comment on attachment 229792 [details]
Patch

Attachment 229792 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5558055454375936

New failing tests:
http/tests/misc/favicon-as-image.html
fast/images/favicon-as-image.html
Comment 7 Build Bot 2014-04-21 01:53:13 PDT 
Created attachment 229794 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 8 Build Bot 2014-04-21 02:48:32 PDT 
Comment on attachment 229792 [details]
Patch

Attachment 229792 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6380866498461696

New failing tests:
http/tests/misc/favicon-as-image.html
fast/images/favicon-as-image.html
Comment 9 Build Bot 2014-04-21 02:48:36 PDT 
Created attachment 229796 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 10 Darin Adler 2014-04-21 10:37:16 PDT 
Created attachment 229805 [details]
Patch
Comment 11 Darin Adler 2014-04-21 10:41:33 PDT 
Created attachment 229807 [details]
Patch
Comment 12 Darin Adler 2014-04-21 10:41:54 PDT 
OK, should really be ready for review now.
Comment 13 Darin Adler 2014-04-21 11:09:14 PDT 
Committed r167598: <http://trac.webkit.org/changeset/167598>
Comment 14 Darin Adler 2014-04-21 11:09:25 PDT 
Comment on attachment 229807 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229807&action=review

> Source/WebCore/loader/FrameLoaderClient.h:306
>          virtual bool allowRunningInsecureContent(bool enabledPerSettings, SecurityOrigin*, const URL&) { return enabledPerSettings; }

Oops, forgot to delete this line. I have it deleted locally. I’ll do that in a follow-up if this gets landed by the commit queue.