Bug 131930 – REGRESSION (r160908): Safari doesn't draw rotated images properly first time

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Darin Adler]

ImageDocument needs to explicitly updateStyleIfNeeded before looking at renderers

[Darin Adler]

<rdar://problem/16345245>

[Darin Adler]

Created attachment 229792 [details]
Patch

[Andreas Kling]

Regressions: Unexpected text-only failures (2)
  fast/images/favicon-as-image.html [ Failure ]
  http/tests/misc/favicon-as-image.html [ Failure ]

[Build Bot]

Comment on attachment 229792 [details]
Patch

Attachment 229792 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6715599019311104

New failing tests:
http/tests/misc/favicon-as-image.html
fast/images/favicon-as-image.html

[Build Bot]

Created attachment 229793 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 229792 [details]
Patch

Attachment 229792 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5558055454375936

New failing tests:
http/tests/misc/favicon-as-image.html
fast/images/favicon-as-image.html

[Build Bot]

Created attachment 229794 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 229792 [details]
Patch

Attachment 229792 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6380866498461696

New failing tests:
http/tests/misc/favicon-as-image.html
fast/images/favicon-as-image.html

[Build Bot]

Created attachment 229796 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Darin Adler]

Created attachment 229805 [details]
Patch

[Darin Adler]

Created attachment 229807 [details]
Patch

[Darin Adler]

OK, should really be ready for review now.

[Darin Adler]

Committed r167598: <http://trac.webkit.org/changeset/167598>

[Darin Adler]

Comment on attachment 229807 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229807&action=review

> Source/WebCore/loader/FrameLoaderClient.h:306
>          virtual bool allowRunningInsecureContent(bool enabledPerSettings, SecurityOrigin*, const URL&) { return enabledPerSettings; }

Oops, forgot to delete this line. I have it deleted locally. I’ll do that in a follow-up if this gets landed by the commit queue.