Bug 131924 - REGRESSION (r166784): Gradient at background of iCloud login page doesn’t go all the way to the bottom
Summary: REGRESSION (r166784): Gradient at background of iCloud login page doesn’t go ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: zalan
URL: https://www.icloud.com
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2014-04-20 22:05 PDT by mitz
Modified: 2014-04-21 17:16 PDT (History)
8 users (show)

See Also:

Attachments
Test reduction (1.13 KB, text/html)
2014-04-21 09:53 PDT, zalan 		no flags Details
Patch (9.46 KB, patch)
2014-04-21 13:35 PDT, zalan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (681.52 KB, application/zip)
2014-04-21 14:40 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (670.19 KB, application/zip)
2014-04-21 14:41 PDT, Build Bot 		no flags Details
Patch (8.51 KB, patch)
2014-04-21 14:54 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-04-20 22:05:49 PDT 
To reproduce: navigate to the URL (log out of iCloud if necessary). There is a gap between the bottom of the page and where the gradient ends, leaving a lighter-colored strip at the bottom.

This was introduced in <http://trac.webkit.org/r166784>, the fix for bug 131144.
Comment 1 mitz 2014-04-20 22:06:52 PDT 
<rdar://problem/16672414>
Comment 2 zalan 2014-04-20 22:10:47 PDT 
Interestingly, that's a multi device pixel gap.
Comment 3 zalan 2014-04-21 09:53:07 PDT 
Created attachment 229803 [details]
Test reduction
Comment 4 zalan 2014-04-21 12:49:13 PDT 
Apparently LayoutUnit precision is not high enough to calculate scale values for contain/cover. Patch is coming up.
Comment 5 zalan 2014-04-21 13:35:45 PDT 
Created attachment 229827 [details]
Patch
Comment 6 Simon Fraser (smfr) 2014-04-21 13:42:27 PDT 
Comment on attachment 229827 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229827&action=review

> Source/WebCore/ChangeLog:15
> +        revealed that tile size computation gives correct results more often when snapping does not dependw on the location.

dependw
Comment 7 Build Bot 2014-04-21 14:39:58 PDT 
Comment on attachment 229827 [details]
Patch

Attachment 229827 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5541439836520448

New failing tests:
fast/backgrounds/hidpi-generated-gradient-background-on-subpixel-position.html
fast/backgrounds/hidpi-background-image-contain-cover-scale-needs-more-precision.html
Comment 8 Build Bot 2014-04-21 14:40:01 PDT 
Created attachment 229834 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 9 Build Bot 2014-04-21 14:41:54 PDT 
Comment on attachment 229827 [details]
Patch

Attachment 229827 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4626646162210816

New failing tests:
fast/backgrounds/hidpi-generated-gradient-background-on-subpixel-position.html
Comment 10 Build Bot 2014-04-21 14:41:57 PDT 
Created attachment 229835 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 11 zalan 2014-04-21 14:54:04 PDT 
Created attachment 229837 [details]
Patch
Comment 12 zalan 2014-04-21 14:54:17 PDT 
Comment on attachment 229837 [details]
Patch

EWS
Comment 13 WebKit Commit Bot 2014-04-21 17:16:03 PDT 
Comment on attachment 229837 [details]
Patch

Clearing flags on attachment: 229837

Committed r167637: <http://trac.webkit.org/changeset/167637>
Comment 14 WebKit Commit Bot 2014-04-21 17:16:08 PDT 
All reviewed patches have been landed.  Closing bug.