Bug 131922 - Add Element.matches, the standard name for webkitMatchesSelector
Summary: Add Element.matches, the standard name for webkitMatchesSelector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: WebExposed
Depends on: 131929
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-20 18:09 PDT by Benjamin Poulain
Modified: 2014-04-21 15:26 PDT (History)
8 users (show)

See Also:

Attachments
Patch (38.69 KB, patch)
2014-04-20 18:12 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (39.20 KB, patch)
2014-04-21 13:46 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-04-20 18:09:32 PDT 
Add Element.matches, the standard name for webkitMatchesSelector
Comment 1 Benjamin Poulain 2014-04-20 18:12:20 PDT 
Created attachment 229779 [details]
Patch
Comment 2 Andreas Kling 2014-04-20 19:53:00 PDT 
Comment on attachment 229779 [details]
Patch

Nice. r=me
Comment 3 Benjamin Poulain 2014-04-20 23:08:33 PDT 
Comment on attachment 229779 [details]
Patch

Clearing flags on attachment: 229779

Committed r167584: <http://trac.webkit.org/changeset/167584>
Comment 4 Benjamin Poulain 2014-04-20 23:08:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2014-04-21 00:04:32 PDT 
This somehow broke Objective-C bindings generation. Ben, are you around to take a look?

http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20(Tests)/builds/5357/steps/bindings-generation-tests/logs/stdio
Comment 6 WebKit Commit Bot 2014-04-21 00:22:56 PDT 
Re-opened since this is blocked by bug 131929
Comment 7 Alexey Proskuryakov 2014-04-21 00:26:27 PDT 
Rolled out in <https://trac.webkit.org/r167588>. The diff was:

 - (void)orange
 {
     WebCore::JSMainThreadNullState state;
-    IMPL->orange();
+    IMPL->banana();
 }
Comment 8 Benjamin Poulain 2014-04-21 13:46:41 PDT 
Created attachment 229830 [details]
Patch
Comment 9 Benjamin Poulain 2014-04-21 15:26:17 PDT 
Committed r167631: <http://trac.webkit.org/changeset/167631>