js/dom/JSON-stringify.html started to ASSERT very frequently after <http://trac.webkit.org/r167530>:
6 com.apple.WebCore 0x000000010d4513b5 WebCore::JSDOMGlobalObject::~JSDOMGlobalObject() + 85 (JSDOMGlobalObject.h:43)
7 com.apple.WebCore 0x000000010d4e7c11 WebCore::JSDOMWindowBase::~JSDOMWindowBase() + 49 (JSDOMWindowBase.h:37)
8 com.apple.WebCore 0x000000010d4e4615 WebCore::JSDOMWindowBase::~JSDOMWindowBase() + 21 (JSDOMWindowBase.h:37)
9 com.apple.WebCore 0x000000010d4e3885 WebCore::JSDOMWindowBase::destroy(JSC::JSCell*) + 21 (JSDOMWindowBase.cpp:84)
Worst of all, it's likely some preceding test that's breaking things.
How important was r167530? It broke at least two tests in mysterious ways, can we just not do this at this time?
I can reproduce with:
run-webkit-tests --child-processes=1 inspector/dom/content-flow-list.html js/dom/JSON-parse.html --v --repeat-each 10
So, it's inspector/dom/content-flow-list.html that causes this assertion failure.
That change is important. I'll look into the crashes / failures. Unlike the GC failure, this one is actually related to my change.
There are many tests that randomly assert because of this - at least half a dozen of js/dom tests do, apparently depending on how quickly garbage collection occurs. So, it would not make a lot of sense to mark these as flakily crashing.
Skipped all inspector/dom tests in <http://trac.webkit.org/r167593>, in hopes that these are the only ones that cause trouble. Also commented out flakiness expectations that we had for some of these.
I suspect https://trac.webkit.org/changeset/167647 might have fixed this.
I don't see these anymore, closing this bug.