WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
131908
[Mac] Unable to select 'Off' or 'Auto' from track menu when tracks consist of unsupported track types
https://bugs.webkit.org/show_bug.cgi?id=131908
Summary
[Mac] Unable to select 'Off' or 'Auto' from track menu when tracks consist of...
Brent Fulgham
Reported
2014-04-19 22:17:48 PDT
When Webkit is asked to display a media track menu with out-of-band tracks of an unsupported track type (e.g., TTML), you are not able to select the 'Off' menu item. There is no user-visible impact here (since the track doesn't display whether it is selected or not), but it's unexpected behavior to select the 'Off' menu element, but for the menu to not show an 'Off' checked state.
Attachments
Patch
(1.65 KB, patch)
2014-04-19 22:21 PDT
,
Brent Fulgham
eric.carlson
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2014-04-19 22:21:22 PDT
Created
attachment 229756
[details]
Patch
Brent Fulgham
Comment 2
2014-04-19 22:21:59 PDT
Comment on
attachment 229756
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=229756&action=review
> Source/WebCore/html/HTMLMediaElement.cpp:3717 > + } else if (trackToSelect == TextTrack::captionMenuOffItem()) {
I'm not sure if this would be better to just incorporate into the loop above?
Eric Carlson
Comment 3
2014-04-20 20:23:29 PDT
Comment on
attachment 229756
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=229756&action=review
> Source/WebCore/ChangeLog:10 > + (WebCore::HTMLMediaElement::parseAttribute): When the user selects 'Off', make sure the currently 'showing'
prepare-ChangeLog doesn't like something about HTMLMediaElement.cpp so it thinks all changes are in parseAttribute, so you should fix this entry manually.
>> Source/WebCore/html/HTMLMediaElement.cpp:3717 >> + } else if (trackToSelect == TextTrack::captionMenuOffItem()) { > > I'm not sure if this would be better to just incorporate into the loop above?
It could be, but I think it is probably easier to follow the logic this way.
> Source/WebCore/html/HTMLMediaElement.cpp:3720 > + if (!trackToSelect || track != trackToSelect)
trackToSelect is TextTrack::captionMenuOffItem so it can't be NULL, and TextTrack::captionMenuOffItem won't be in textTracks(), so this check can be removed.
Brent Fulgham
Comment 4
2014-04-20 21:28:59 PDT
Committed
r167578
: <
http://trac.webkit.org/changeset/167578
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug