WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
131897
Inline allocate Arguments objects in the DFG
https://bugs.webkit.org/show_bug.cgi?id=131897
Summary
Inline allocate Arguments objects in the DFG
Mark Hahnenberg
Reported
2014-04-19 13:56:29 PDT
Many libraries/frameworks depend on the arguments object for overloaded API entry points. This is the first step to making Arguments fast(er). We'll duplicate the logic in Arguments::create for now, and take the slow path for complicated cases like slow arguments, tearing off for strict mode, etc.
Attachments
Patch
(12.39 KB, patch)
2014-04-19 13:59 PDT
,
Mark Hahnenberg
no flags
Details
Formatted Diff
Diff
Patch
(11.92 KB, patch)
2014-04-19 14:40 PDT
,
Mark Hahnenberg
ggaren
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1
2014-04-19 13:59:50 PDT
Created
attachment 229745
[details]
Patch
Mark Hahnenberg
Comment 2
2014-04-19 14:40:23 PDT
Created
attachment 229748
[details]
Patch
Mark Hahnenberg
Comment 3
2014-04-19 14:46:04 PDT
This is performance neutral on the benchmarks we track.
Geoffrey Garen
Comment 4
2014-04-19 16:06:02 PDT
Comment on
attachment 229748
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=229748&action=review
r=me
> Source/JavaScriptCore/runtime/Arguments.h:60 > +
Revert.
Mark Hahnenberg
Comment 5
2014-04-21 08:12:07 PDT
Committed
r167591
: <
http://trac.webkit.org/changeset/167591
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug