Bug 131897 - Inline allocate Arguments objects in the DFG
Summary: Inline allocate Arguments objects in the DFG
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-19 13:56 PDT by Mark Hahnenberg
Modified: 2014-04-21 08:12 PDT (History)
0 users

See Also:

Attachments
Patch (12.39 KB, patch)
2014-04-19 13:59 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (11.92 KB, patch)
2014-04-19 14:40 PDT, Mark Hahnenberg 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-04-19 13:56:29 PDT 
Many libraries/frameworks depend on the arguments object for overloaded API entry points. This is the first step to making Arguments fast(er). We'll duplicate the logic in Arguments::create for now, and take the slow path for complicated cases like slow arguments, tearing off for strict mode, etc.
Comment 1 Mark Hahnenberg 2014-04-19 13:59:50 PDT 
Created attachment 229745 [details]
Patch
Comment 2 Mark Hahnenberg 2014-04-19 14:40:23 PDT 
Created attachment 229748 [details]
Patch
Comment 3 Mark Hahnenberg 2014-04-19 14:46:04 PDT 
This is performance neutral on the benchmarks we track.
Comment 4 Geoffrey Garen 2014-04-19 16:06:02 PDT 
Comment on attachment 229748 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229748&action=review

r=me

> Source/JavaScriptCore/runtime/Arguments.h:60
> +        

Revert.
Comment 5 Mark Hahnenberg 2014-04-21 08:12:07 PDT 
Committed r167591: <http://trac.webkit.org/changeset/167591>