Bug 131879 - bmalloc: Mutex should be harder to use wrong
Summary: bmalloc: Mutex should be harder to use wrong
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-18 21:05 PDT by Geoffrey Garen
Modified: 2014-04-19 11:37 PDT (History)
1 user (show)

See Also:

Attachments
Patch (41.29 KB, patch)
2014-04-18 21:09 PDT, Geoffrey Garen 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2014-04-18 21:05:12 PDT 
bmalloc: Mutex should be harder to use wrong
Comment 1 Geoffrey Garen 2014-04-18 21:09:42 PDT 
Created attachment 229713 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-18 21:11:31 PDT 
Attachment 229713 [details] did not pass style-queue:


ERROR: Source/bmalloc/bmalloc/StaticMutex.h:40:  try_lock is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/bmalloc/bmalloc/StaticMutex.h:60:  StaticMutex::try_lock is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/bmalloc/bmalloc/StaticMutex.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 3 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2014-04-19 00:33:21 PDT 
Comment on attachment 229713 [details]
Patch

r=me
Comment 4 Geoffrey Garen 2014-04-19 11:37:21 PDT 
Committed r167540: <http://trac.webkit.org/changeset/167540>