Bug 131874 - [iOS][WK2] Make dynamic viewport size update content aware
Summary: [iOS][WK2] Make dynamic viewport size update content aware
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-18 19:35 PDT by Benjamin Poulain
Modified: 2014-04-21 13:11 PDT (History)
2 users (show)

See Also:


Attachments
Patch (13.17 KB, patch)
2014-04-18 19:58 PDT, Benjamin Poulain
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-04-18 19:35:38 PDT
[iOS][WK2] Make dynamic viewport size update content aware
Comment 1 Benjamin Poulain 2014-04-18 19:58:21 PDT
Created attachment 229705 [details]
Patch
Comment 2 Tim Horton 2014-04-18 21:13:36 PDT
Comment on attachment 229705 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229705&action=review

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1777
> +    m_dynamicSizeUpdateHistory.add(std::pair<IntSize, float>(oldContentSize, oldPageScaleFactor), IntPoint(frameView.scrollOffset()));

I think you can use make_pair with no template arguments?

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1794
> +                Frame& containingFrame = *node->document().frame();

why the containingFrame temporary?

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1848
> +        const auto& previousPosition = m_dynamicSizeUpdateHistory.find(std::pair<IntSize, float>(newContentSize, scale));

ditto
Comment 3 Benjamin Poulain 2014-04-21 13:11:10 PDT
Committed r167614: <http://trac.webkit.org/changeset/167614>