Bug 131857 - [Media] Clean up localized strings in controls
Summary: [Media] Clean up localized strings in controls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-18 14:12 PDT by Dean Jackson
Modified: 2014-04-21 11:07 PDT (History)
10 users (show)

See Also:

Attachments
Patch (15.37 KB, patch)
2014-04-18 14:21 PDT, Dean Jackson 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-04-18 14:12:04 PDT 
There are a few things we can clean up in string localization.

- We don't really need a function to return a static table
- We don't need different tables for OS X and iOS
- We should have the ability to do template replacement while getting the string
Comment 1 Radar WebKit Bug Importer 2014-04-18 14:15:45 PDT 
<rdar://problem/16663005>
Comment 2 Dean Jackson 2014-04-18 14:21:25 PDT 
Created attachment 229675 [details]
Patch
Comment 3 Dean Jackson 2014-04-21 11:07:00 PDT 
Committed r167596: <http://trac.webkit.org/changeset/167596>