Bug 131852 - Correct some issues small issues in WK2 file upload InjectedBundle APIs
Summary: Correct some issues small issues in WK2 file upload InjectedBundle APIs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-18 12:48 PDT by Joseph Pecoraro
Modified: 2014-04-18 16:11 PDT (History)
3 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.05 KB, patch)
2014-04-18 12:50 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-04-18 12:48:13 PDT 
There are some minor issues in WK2 file upload injected bundle APIs.

  - the default for shouldGenerateFileForUpload should return a null string, not an empty string. null string is special.
  - an injected bundle API is pre-checking the wrong function
Comment 1 Joseph Pecoraro 2014-04-18 12:50:00 PDT 
Created attachment 229666 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2014-04-18 13:44:15 PDT 
Comment on attachment 229666 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=229666&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h:60
>      virtual WTF::String generateFileForUpload(WebKit::WebPage*, const WTF::String& originalFilePath) { UNUSED_PARAM(originalFilePath); return emptyString(); }

I suppose this could also return a null string. However null string is only really important in should. As null string => should not, but anything else => should.
Comment 3 WebKit Commit Bot 2014-04-18 16:11:34 PDT 
Comment on attachment 229666 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 229666

Committed r167514: <http://trac.webkit.org/changeset/167514>
Comment 4 WebKit Commit Bot 2014-04-18 16:11:40 PDT 
All reviewed patches have been landed.  Closing bug.