Bug 131852 – Correct some issues small issues in WK2 file upload InjectedBundle APIs

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Joseph Pecoraro]

There are some minor issues in WK2 file upload injected bundle APIs.

  - the default for shouldGenerateFileForUpload should return a null string, not an empty string. null string is special.
  - an injected bundle API is pre-checking the wrong function

[Joseph Pecoraro]

Created attachment 229666 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 229666 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=229666&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h:60
>      virtual WTF::String generateFileForUpload(WebKit::WebPage*, const WTF::String& originalFilePath) { UNUSED_PARAM(originalFilePath); return emptyString(); }

I suppose this could also return a null string. However null string is only really important in should. As null string => should not, but anything else => should.

[WebKit Commit Bot]

Comment on attachment 229666 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 229666

Committed r167514: <http://trac.webkit.org/changeset/167514>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.