Bug 131851 - bmalloc: Added an XSmall line size
Summary: bmalloc: Added an XSmall line size
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-18 12:35 PDT by Geoffrey Garen
Modified: 2014-05-10 12:47 PDT (History)
1 user (show)

See Also:


Attachments
Patch (60.38 KB, patch)
2014-04-18 12:44 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2014-04-18 12:35:46 PDT
bmalloc: Added an XSmall line size
Comment 1 Geoffrey Garen 2014-04-18 12:44:07 PDT
Created attachment 229665 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-18 12:45:22 PDT
Attachment 229665 [details] did not pass style-queue:


ERROR: Source/bmalloc/bmalloc/Heap.cpp:141:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2014-04-18 13:18:22 PDT
Committed r167502: <http://trac.webkit.org/changeset/167502>
Comment 4 Geoffrey Garen 2014-04-19 13:41:14 PDT
This caused a large object validation ASSERT on the Facebook benchmark in debug builds. Most likely, it just exposed a pre-existing large object bug by moving more objects into the large object space.
Comment 5 Geoffrey Garen 2014-04-19 13:42:03 PDT
Rolled out in <http://trac.webkit.org/changeset/167546>.
Comment 6 Geoffrey Garen 2014-05-10 12:47:48 PDT
Comment on attachment 229665 [details]
Patch

Clearing review flag to remove this from the landing queue.