REOPENED 131851
bmalloc: Added an XSmall line size 
https://bugs.webkit.org/show_bug.cgi?id=131851
Summary bmalloc: Added an XSmall line size
Geoffrey Garen
Reported 2014-04-18 12:35:46 PDT
bmalloc: Added an XSmall line size
Attachments
Patch (60.38 KB, patch)
2014-04-18 12:44 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2014-04-18 12:44:07 PDT
Created attachment 229665 [details] Patch
WebKit Commit Bot
Comment 2 2014-04-18 12:45:22 PDT
Attachment 229665 [details] did not pass style-queue: ERROR: Source/bmalloc/bmalloc/Heap.cpp:141: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2014-04-18 13:18:22 PDT
Committed r167502: <http://trac.webkit.org/changeset/167502>
Geoffrey Garen
Comment 4 2014-04-19 13:41:14 PDT
This caused a large object validation ASSERT on the Facebook benchmark in debug builds. Most likely, it just exposed a pre-existing large object bug by moving more objects into the large object space.
Geoffrey Garen
Comment 5 2014-04-19 13:42:03 PDT
Rolled out in <http://trac.webkit.org/changeset/167546>.
Geoffrey Garen
Comment 6 2014-05-10 12:47:48 PDT
Comment on attachment 229665 [details] Patch Clearing review flag to remove this from the landing queue.
Note You need to log in before you can comment on or make changes to this bug.