Bug 131850 - Options::maximumExecutionCountsBetweenCheckpoints() should be higher for DFG->FTL tier-up but the same for other tier-ups
Summary: Options::maximumExecutionCountsBetweenCheckpoints() should be higher for DFG-...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Reported: 2014-04-18 12:34 PDT by Filip Pizlo
Modified: 2014-04-18 16:21 PDT (History)
7 users (show)

See Also:

the patch (16.63 KB, patch)
2014-04-18 12:36 PDT, Filip Pizlo
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-04-18 12:34:44 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2014-04-18 12:36:06 PDT
Created attachment 229664 [details]
the patch
Comment 2 Mark Hahnenberg 2014-04-18 13:03:32 PDT
Comment on attachment 229664 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229664&action=review

r=me after tests + perf numbers come back green :-)

> Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp:90
> +    default:

Some platforms might complain about clippedValue not being defined prior to use here. You might want to set it to some bogus value in this branch.
Comment 3 Filip Pizlo 2014-04-18 16:21:07 PDT
Landed in http://trac.webkit.org/changeset/167515