Bug 131833 - [Mac] AttributedStringTest API tests fail with async text input
Summary: [Mac] AttributedStringTest API tests fail with async text input
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-17 18:02 PDT by Alexey Proskuryakov
Modified: 2014-04-18 10:08 PDT (History)
1 user (show)

See Also:

Attachments
proposed fix (4.43 KB, patch)
2014-04-17 18:05 PDT, Alexey Proskuryakov 		enrica: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-04-17 18:02:41 PDT 
WKView doesn't implement old NSTextInputClient methods when async text input is enabled.
Comment 1 Alexey Proskuryakov 2014-04-17 18:05:21 PDT 
Created attachment 229605 [details]
proposed fix
Comment 2 Enrica Casucci 2014-04-18 10:05:42 PDT 
Comment on attachment 229605 [details]
proposed fix

Looks good to me.
Comment 3 Alexey Proskuryakov 2014-04-18 10:08:50 PDT 
Committed <http://trac.webkit.org/r167491>.