Bug 131824 – [CSS Blending] Remove support for non-separable blend modes from mix-blend-mode

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Rik Cabanier]

OSX and iOS don't support the non-separable blend modes (hue, saturation, color and luminosity) in composited mode.
The spec (http://dev.w3.org/fxtf/compositing-1/#mix-blend-mode) is currently in CR but will be updated.

[Rik Cabanier]

Created attachment 229598 [details]
Patch

[Dean Jackson]

Comment on attachment 229598 [details]
Patch

r=me but I suggest you remove the backend code as well. The stuff in BlahFiltersBlah that is empty code with a comment saying they are not implemented.

[Rik Cabanier]

Created attachment 229808 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 229808 [details]
Patch

Rejecting attachment 229808 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[Simon Fraser (smfr)]

Comment on attachment 229808 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229808&action=review

> Source/WebCore/ChangeLog:8
> +        Removed support for non-sep blend modes from the CSS parser.

Please don't abbreviate non-seperable.

[Rik Cabanier]

Created attachment 229824 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 229824 [details]
Patch for landing

Clearing flags on attachment: 229824

Committed r167620: <http://trac.webkit.org/changeset/167620>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.