Bug 131823 - FTL::fail() should manage memory "correctly"
Summary: FTL::fail() should manage memory "correctly"
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Reported: 2014-04-17 15:28 PDT by Filip Pizlo
Modified: 2014-04-17 15:31 PDT (History)
7 users (show)

See Also:

the patch (1.21 KB, patch)
2014-04-17 15:29 PDT, Filip Pizlo
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-04-17 15:28:03 PDT
We have some objects that the DFG::Plan points to but that are owned by DFG::Graph until such time as they are owned by DFG::JITCode.  It's weird, and a lot of this is a deeper spaghetti that needs to be fixed.  But for now, at least make FTL::fail() follow the protocol for InlineCallFrames.
Comment 1 Filip Pizlo 2014-04-17 15:29:31 PDT
Created attachment 229584 [details]
the patch
Comment 2 Filip Pizlo 2014-04-17 15:31:38 PDT
Landed in http://trac.webkit.org/changeset/167456