Bug 131813 - _webProcessIdentifier should return 0 if the web process crashed
Summary: _webProcessIdentifier should return 0 if the web process crashed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-17 13:50 PDT by Pratik Solanki
Modified: 2014-04-17 15:39 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.89 KB, patch)
2014-04-17 13:52 PDT, Pratik Solanki 		no flags Details | Formatted Diff | Diff
Patch (1.33 KB, patch)
2014-04-17 14:27 PDT, Pratik Solanki 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2014-04-17 13:50:52 PDT 
Add SPI to see if web process is live or got killed
Comment 1 Pratik Solanki 2014-04-17 13:52:05 PDT 
Created attachment 229572 [details]
Patch
Comment 2 Anders Carlsson 2014-04-17 13:53:48 PDT 
Comment on attachment 229572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229572&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1411
> +- (BOOL)_isValid
> +{
> +    return _page->isValid();
> +}

I think this name is too generic. How about _hasWebProcess?

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:121
> +- (BOOL)_isValid;

This should be a property.
Comment 3 Pratik Solanki 2014-04-17 14:16:47 PDT 
Better way - just make _webProcessIdentifier return 0 if the process was killed.
Comment 4 Pratik Solanki 2014-04-17 14:27:30 PDT 
Created attachment 229577 [details]
Patch
Comment 5 Pratik Solanki 2014-04-17 15:39:55 PDT 
Committed r167457: <http://trac.webkit.org/changeset/167457>