Bug 131795 - [GTK] [Gardening] Update some test expectations for GTK
Summary: [GTK] [Gardening] Update some test expectations for GTK
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-17 09:26 PDT by Eduardo Lima Mitev
Modified: 2014-04-17 12:13 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.31 KB, patch)
2014-04-17 09:27 PDT, Eduardo Lima Mitev
no flags Details | Formatted Diff | Diff
Patch (3.29 KB, patch)
2014-04-17 11:09 PDT, Eduardo Lima Mitev
elima: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eduardo Lima Mitev 2014-04-17 09:26:30 PDT
[GTK] [Gardening] Update some test expectations for GTK
Comment 1 Eduardo Lima Mitev 2014-04-17 09:27:10 PDT
Created attachment 229553 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-17 10:26:43 PDT
Comment on attachment 229553 [details]
Patch

Rejecting attachment 229553 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 229553, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/5244854577659904
Comment 3 Carlos Alberto Lopez Perez 2014-04-17 10:29:05 PDT
(In reply to comment #2)
> (From update of attachment 229553 [details])
> Rejecting attachment 229553 [details] from commit-queue.
> 
> Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 229553, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
> 
> /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
> 
> Full output: http://webkit-queues.appspot.com/results/5244854577659904

I think you forgot to add the 

"Unreviewed GTK gardening..."

phrase to the changelog
Comment 4 Eduardo Lima Mitev 2014-04-17 11:09:07 PDT
Created attachment 229562 [details]
Patch
Comment 5 Carlos Alberto Lopez Perez 2014-04-17 12:07:16 PDT
Seems this was already manually landed by mrobinson on http://trac.webkit.org/changeset/167438

I guess you can close this bug
Comment 6 Eduardo Lima Mitev 2014-04-17 12:13:13 PDT
Martin Robinson already committed the first patch. Thank you.

Closing.