WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 131788
Remove CANVAS_PATH where possible
https://bugs.webkit.org/show_bug.cgi?id=131788
Summary
Remove CANVAS_PATH where possible
Dirk Schulze
Reported
2014-04-16 23:26:16 PDT
Since FF and Chrome ship an interoperable subset of Path2D it is time to remove CANVAS_PATH where possible.
Attachments
Patch
(5.91 KB, patch)
2014-04-16 23:43 PDT
,
Dirk Schulze
no flags
Details
Formatted Diff
Diff
Patch
(6.17 KB, patch)
2014-04-17 06:51 PDT
,
Dirk Schulze
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Dirk Schulze
Comment 1
2014-04-16 23:43:47 PDT
Created
attachment 229525
[details]
Patch
Dirk Schulze
Comment 2
2014-04-17 06:51:56 PDT
Created
attachment 229540
[details]
Patch
Dean Jackson
Comment 3
2014-04-17 13:00:18 PDT
Comment on
attachment 229540
[details]
Patch r+, but I don't really understand why you don't remove the flag entirely.
Dirk Schulze
Comment 4
2014-04-17 13:14:48 PDT
(In reply to
comment #3
)
> (From update of
attachment 229540
[details]
) > r+, but I don't really understand why you don't remove the flag entirely.
Talked on IRC about that. The flag needs to stay because addPath is not ready for shipping yet. Browsers should disable CANVAS_PATH on shipping now.
WebKit Commit Bot
Comment 5
2014-04-17 13:32:46 PDT
Comment on
attachment 229540
[details]
Patch Clearing flags on attachment: 229540 Committed
r167451
: <
http://trac.webkit.org/changeset/167451
>
WebKit Commit Bot
Comment 6
2014-04-17 13:32:51 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug