Bug 131779 – On iOS keep network process running using a process assertion rather than a boost

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Gavin Barraclough]

.

[Gavin Barraclough]

Created attachment 229507 [details]
Fix

[WebKit Commit Bot]

Attachment 229507 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/ProcessAssertion.mm:40:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Benjamin Poulain]

Comment on attachment 229507 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=229507&action=review

> Source/WebKit2/UIProcess/WebProcessProxy.h:225
> +    std::unique_ptr<ProcessAssertion> m_assertion;

Let's move this guy to ChildProcessProxy.

> Source/WebKit2/UIProcess/ios/ProcessAssertion.h:39
> +    enum State {

typed enum?

> Source/WebKit2/UIProcess/ios/ProcessAssertion.mm:36
> +const BKSProcessAssertionFlags BackgroundTabFlags = (BKSProcessAssertionAllowIdleSleep);
> +const BKSProcessAssertionFlags ForegroundTabFlags = (BKSProcessAssertionAllowIdleSleep | BKSProcessAssertionPreventTaskSuspend | BKSProcessAssertionAllowSuspendOnSleep | BKSProcessAssertionWantsForegroundResourcePriority | BKSProcessAssertionPreventTaskThrottleDown);

Lowercase first letter for variable names.

We'll probably need something configurable for BKSProcessAssertionPreventTaskThrottleDown on the WebProcess.

> Source/WebKit2/UIProcess/ios/ProcessAssertion.mm:59
> +    m_assertionState = assertionState;

Let's assign this before the out call in case some delegate cause us to re-enter.

[Gavin Barraclough]

Transmitting file data .........
Committed revision 167410.