Bug 131777 - [New Multicolumn] REGRESSION: Column sets don't recalculate style when styles change (e.g., zooming)
Summary: [New Multicolumn] REGRESSION: Column sets don't recalculate style when styles...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-16 17:26 PDT by Dave Hyatt
Modified: 2014-04-17 09:46 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.61 KB, patch)
2014-04-17 09:36 PDT, Dave Hyatt 		enrica: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2014-04-16 17:26:02 PDT 
Zoom any new multicolumn layout. The fonts don't update like they are supposed to. It looks like the styles of the multicolumn sets aren't being properly updated.
Comment 1 Dave Hyatt 2014-04-17 09:36:17 PDT 
Created attachment 229554 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-17 09:38:20 PDT 
Attachment 229554 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:1873:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:1873:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Enrica Casucci 2014-04-17 09:42:36 PDT 
Comment on attachment 229554 [details]
Patch

Looks good to me.
Comment 4 Dave Hyatt 2014-04-17 09:46:08 PDT 
Landed in r167429.