Bug 131775 - Images dragged from WebKit1 on 2x displays are too big
Summary: Images dragged from WebKit1 on 2x displays are too big
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-16 16:47 PDT by Tim Horton
Modified: 2014-04-16 17:00 PDT (History)
2 users (show)

See Also:

Attachments
patch (1.50 KB, patch)
2014-04-16 16:52 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-04-16 16:47:54 PDT 
WebCore hands us an NSImage with large logical size; WebKit2 scales down by the page's device scale factor; WebKit1 does not.

WebCore handing WebKit2 an image with the right logical size won't work, because WebKit2 has to put it in a ShareableBitmap and throw it across the process boundary.

So, instead, scale it down in WebKit1 just like we do in WebKit2.

<rdar://problem/15933525>
Comment 1 Tim Horton 2014-04-16 16:52:04 PDT 
Created attachment 229499 [details]
patch
Comment 2 Tim Horton 2014-04-16 17:00:37 PDT 
http://trac.webkit.org/changeset/167403