Bug 131767 – Local files should not be allowed to read pasteboard data during drag

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Alexey Proskuryakov]

As implemented in <http://trac.webkit.org/changeset/6840> for Dashboard, local files are allowed to read pasteboard data during drag, while normal documents can only do that during drop even handling.

Even local documents should not be allowed to sniff content simply dragged over them, they are not that trusted. I'm going to make this a Dashboard quirk instead.

[Alexey Proskuryakov]

Created attachment 230191 [details]
proposed patch

[WebKit Commit Bot]

Comment on attachment 230191 [details]
proposed patch

Clearing flags on attachment: 230191

Committed r167850: <http://trac.webkit.org/changeset/167850>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 230191 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230191&action=review

> Source/WebCore/page/DragController.cpp:186
> +        DataTransferAccessPolicy::Readable : DataTransferAccessPolicy::TypesReadable;

Missing indentation here. I normally find that this:

    <long line>
        ? x : y;

Is more readable than:

    <long line> ?
        x : y;

But the code above is:

    <long line> ?
    x : y;