WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
13175
Make apollo mac project files for JavaScriptCore actually build something
https://bugs.webkit.org/show_bug.cgi?id=13175
Summary
Make apollo mac project files for JavaScriptCore actually build something
Chris Brichford
Reported
2007-03-23 15:24:01 PDT
Bug to track work needed to get JavaScriptCore compiling for mac version of apollo port.
Attachments
patch to get JavaScriptCore apollo mac project working
(74.21 KB, patch)
2007-03-23 15:27 PDT
,
Chris Brichford
aroben
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Brichford
Comment 1
2007-03-23 15:27:46 PDT
Created
attachment 13789
[details]
patch to get JavaScriptCore apollo mac project working
Adam Roben (:aroben)
Comment 2
2007-03-23 15:31:55 PDT
Comment on
attachment 13789
[details]
patch to get JavaScriptCore apollo mac project working +++ JavaScriptCore/JavaScriptCore.apolloproj/ForwardingSources/grammar.cpp (revision 0) @@ -0,0 +1,5 @@ +// This file includes a derived source file from the build output tree. +// Since the location of the derived sources depends on which configuration +// we are building, we need to use the include path ( which can be +// different for each configuration ) to reference the derived source file. +#include <DerivedSources/grammar.cpp> Have you looked to see how the Mac build handles this? I think there's a way to accomplish this without a ForwardingSources directory.
Chris Brichford
Comment 3
2007-03-23 15:35:24 PDT
If I remember correctly. The mac projects reference the source files out of the build directory. However the locations of the derived sources in our build depends on the configuration name which is not something xcode is too happy about. Our MSVC ( Visual Studio ) build works better if we have these "ForwardingSources" type of things as well.
Chris Brichford
Comment 4
2007-03-23 15:37:19 PDT
Also notice that the window port already has grammerWrapper.cpp, which is basically the same thing I have.
Adam Roben (:aroben)
Comment 5
2007-03-23 15:39:07 PDT
(In reply to
comment #3
)
> If I remember correctly. The mac projects reference the source files out of > the build directory. However the locations of the derived sources in our build > depends on the configuration name which is not something xcode is too happy > about. Our MSVC ( Visual Studio ) build works better if we have these > "ForwardingSources" type of things as well. >
The Mac project puts the DerivedSources in a configuration-specific location, as well ({Debug,Release,Production}/DerivedSources/{JavaScriptCore,WebCore,WebKit}). I'm no Xcode expert, but I'm sure there's a way to do it.
Adam Roben (:aroben)
Comment 6
2007-03-23 15:39:42 PDT
(In reply to
comment #4
)
> Also notice that the window port already has grammerWrapper.cpp, which is > basically the same thing I have. >
Yeah, this isn't too big of an issue, especially since it's within the JavaScriptCore.apolloproj directory. r=me
Adam Roben (:aroben)
Comment 7
2007-03-23 15:43:03 PDT
Landed as
r20455
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug