Bug 13175 - Make apollo mac project files for JavaScriptCore actually build something
Summary: Make apollo mac project files for JavaScriptCore actually build something
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 523.x (Safari 3)
Hardware: Macintosh OS X 10.4
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-23 15:24 PDT by Chris Brichford
Modified: 2007-03-23 15:43 PDT (History)
1 user (show)

See Also:


Attachments
patch to get JavaScriptCore apollo mac project working (74.21 KB, patch)
2007-03-23 15:27 PDT, Chris Brichford
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Brichford 2007-03-23 15:24:01 PDT
Bug to track work needed to get JavaScriptCore compiling for mac version of apollo port.
Comment 1 Chris Brichford 2007-03-23 15:27:46 PDT
Created attachment 13789 [details]
patch to get JavaScriptCore apollo mac project working
Comment 2 Adam Roben (:aroben) 2007-03-23 15:31:55 PDT
Comment on attachment 13789 [details]
patch to get JavaScriptCore apollo mac project working

+++ JavaScriptCore/JavaScriptCore.apolloproj/ForwardingSources/grammar.cpp	(revision 0)
@@ -0,0 +1,5 @@
+// This file includes a derived source file from the build output tree.
+// Since the location of the derived sources depends on which configuration
+// we are building, we need to use the include path ( which can be
+// different for each configuration ) to reference the derived source file.
+#include <DerivedSources/grammar.cpp>

   Have you looked to see how the Mac build handles this? I think there's a way to accomplish this without a ForwardingSources directory.
Comment 3 Chris Brichford 2007-03-23 15:35:24 PDT
If I remember correctly.  The mac projects reference the source files out of the build directory.  However the locations of the derived sources in our build depends on the configuration name which is not something xcode is too happy about.  Our MSVC ( Visual Studio ) build works better if we have these "ForwardingSources" type of things as well.
Comment 4 Chris Brichford 2007-03-23 15:37:19 PDT
Also notice that the window port already has grammerWrapper.cpp, which is basically the same thing I have.
Comment 5 Adam Roben (:aroben) 2007-03-23 15:39:07 PDT
(In reply to comment #3)
> If I remember correctly.  The mac projects reference the source files out of
> the build directory.  However the locations of the derived sources in our build
> depends on the configuration name which is not something xcode is too happy
> about.  Our MSVC ( Visual Studio ) build works better if we have these
> "ForwardingSources" type of things as well.
> 

The Mac project puts the DerivedSources in a configuration-specific location, as well ({Debug,Release,Production}/DerivedSources/{JavaScriptCore,WebCore,WebKit}). I'm no Xcode expert, but I'm sure there's a way to do it.
Comment 6 Adam Roben (:aroben) 2007-03-23 15:39:42 PDT
(In reply to comment #4)
> Also notice that the window port already has grammerWrapper.cpp, which is
> basically the same thing I have.
> 

Yeah, this isn't too big of an issue, especially since it's within the JavaScriptCore.apolloproj directory.

r=me
Comment 7 Adam Roben (:aroben) 2007-03-23 15:43:03 PDT
Landed as r20455