Bug 131740 - [New Multicolumn] columnNumberForOffset isn't patched yet
Summary: [New Multicolumn] columnNumberForOffset isn't patched yet
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
Depends on:
Reported: 2014-04-16 10:15 PDT by Dave Hyatt
Modified: 2014-04-17 11:48 PDT (History)
5 users (show)

See Also:

Patch (13.15 KB, patch)
2014-04-17 11:17 PDT, Dave Hyatt
enrica: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2014-04-16 10:15:23 PDT
There is code for iOS selection that passes in the "page number" to selection to try to improve selection in vertical books. This hasn't been patched for the new multi-column layout. We should take the opportunity to clean this code up at the same time, i.e., move the function to RenderView, rename it to pageNumberForOffset, and make it clear it's not necessary for generic multi-column.
Comment 1 Dave Hyatt 2014-04-17 11:17:34 PDT
Created attachment 229563 [details]
Comment 2 WebKit Commit Bot 2014-04-17 11:20:05 PDT
Attachment 229563 [details] did not pass style-queue:

ERROR: Source/WebCore/rendering/RenderView.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 8 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Enrica Casucci 2014-04-17 11:45:09 PDT
Comment on attachment 229563 [details]

Looks good to me.
Comment 4 Dave Hyatt 2014-04-17 11:48:49 PDT
Fix landed in r167444.